Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing): support aws xray propagation #11075

Merged
merged 1 commit into from Jun 21, 2023

Conversation

antoine-labarussias-wmx
Copy link
Contributor

@antoine-labarussias-wmx antoine-labarussias-wmx commented Jun 15, 2023

This PR adds support for the AWS X-Ray trace propagation header.

Summary

Because Amazon X-Ray uses a custom trace id format, without proper support of the X-Amzn-Trace-Id header, it's not possible to store kong's traces in xray.

Doc about X-Amzn-Trace-Id:
https://docs.aws.amazon.com/xray/latest/devguide/xray-concepts.html#xray-concepts-tracingheader

Existing implementations in JS and Python:

Checklist

Full changelog

  • Implement support for the AWS X-Ray trace header

@CLAassistant
Copy link

CLAassistant commented Jun 15, 2023

CLA assistant check
All committers have signed the CLA.

@antoine-labarussias-wmx antoine-labarussias-wmx changed the title feat(propagation): support aws xray propagation feat(tracing): support aws xray propagation Jun 15, 2023
Copy link
Contributor

@hanshuebner hanshuebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good overall, thank you for the contribution! Please see my inline comments and add an entry to CHANGELOG.md. If you could suggest what needs to be added to the documentation (source), it'd be much appreciated.

kong/tracing/propagation.lua Show resolved Hide resolved
kong/tracing/propagation.lua Outdated Show resolved Hide resolved
@antoine-labarussias-wmx
Copy link
Contributor Author

Thanks for the review, here is the small PR for the documentation: Kong/docs.konghq.com#5732

Copy link
Contributor

@samugi samugi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall! I just left a couple of minor comments

kong/tracing/propagation.lua Outdated Show resolved Hide resolved
@hanshuebner hanshuebner merged commit 3a56576 into Kong:master Jun 21, 2023
21 checks passed
@hbagdi hbagdi added the author/community PRs from the open-source community (not Kong Inc) label Jun 21, 2023
@outsinre
Copy link
Contributor

cherry-pick to EE?

Copy link
Contributor

@GGabriele GGabriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: sorry, wrong repo 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants