fix(api): schema violation when validating valid plugin configuration #11091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…json` otherwise, the key-value pair of `custom_fields_by_lua` will be converted into nested table if the key contains dot character(s), which will cause schema violation when calling `/schemas/plugins/validate` Fix [FTI-5070](https://konghq.atlassian.net/browse/FTI-5070)
catbro666
force-pushed
the
fix-parse-params-application-json
branch
from
b768b39
to
762f9e7
Compare
catbro666
changed the title
normalize_nested_params for application/json
fffonion
approved these changes
Jun 26, 2023
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
parse_paramsshould not callnormalize_nested_paramsforapplication/json. Otherwise, the key-value pair ofcustom_fields_by_luawill be converted into a nested table if the key contains dot character(s), which will cause schema violation when calling/schemas/plugins/validateChecklist
Full changelog
/schemas/plugins/validateendpoint fails to validate valid plugin configuration when the key ofcustom_fields_by_luacontains dot character(s).Issue reference
Fix FTI-5070