Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): don't fail on route with multiple paths #11158

Merged

Conversation

hanshuebner
Copy link
Contributor

@hanshuebner hanshuebner commented Jun 30, 2023

Summary

In traditional_compatible mode, the router would fail to work if a route with multiple paths but no service would be created.

Checklist

Issue reference

Fixes KAG-1961

@hanshuebner hanshuebner force-pushed the fix/kag-1961-no-service-route-with-multiple-paths branch from 6223008 to 6245e6e Compare June 30, 2023 12:17
@hanshuebner hanshuebner marked this pull request as ready for review June 30, 2023 12:18
kong/router/compat.lua Outdated Show resolved Hide resolved
In `traditional_compatible` mode, the router would fail to work if a
route with multiple paths but no service would be created.

Fixes KAG-1961
@hanshuebner hanshuebner force-pushed the fix/kag-1961-no-service-route-with-multiple-paths branch from 6245e6e to f5ad223 Compare June 30, 2023 13:08
Copy link
Member

@gszr gszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need a backport to older than 3.3?

@hanshuebner hanshuebner merged commit b0bd002 into master Jun 30, 2023
21 checks passed
@hanshuebner hanshuebner deleted the fix/kag-1961-no-service-route-with-multiple-paths branch June 30, 2023 14:29
@team-gateway-bot
Copy link
Collaborator

The backport to release/3.3.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.3.x release/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.3.x
# Create a new branch
git switch --create backport-11158-to-release/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b0bd002f3f573b5eff821ff6cf85278defc2df21
# Push it to GitHub
git push --set-upstream origin backport-11158-to-release/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.3.x

Then, create a pull request where the base branch is release/3.3.x and the compare/head branch is backport-11158-to-release/3.3.x.

@hanshuebner
Copy link
Contributor Author

Does it need a backport to older than 3.3?

No, the change that caused this issue was introduced in 3.3.

hanshuebner added a commit that referenced this pull request Jun 30, 2023
In `traditional_compatible` mode, the router would fail to work if a
route with multiple paths but no service would be created.

Fixes KAG-1961

(cherry picked from commit b0bd002)
hanshuebner added a commit that referenced this pull request Jul 7, 2023
…le paths (#11159)

* fix(router): don't fail on route with multiple paths (#11158)

In `traditional_compatible` mode, the router would fail to work if a
route with multiple paths but no service would be created.

Fixes KAG-1961

(cherry picked from commit b0bd002)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants