Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opentelemetry): make endpoint field referenceable #11220

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

ms2008
Copy link
Contributor

@ms2008 ms2008 commented Jul 13, 2023

Summary

Checklist

Full changelog

  • supports the endpoint parameter of the opentelemetry plugin as referenceable.

Issue reference

Fix KAG-2066

@ms2008
Copy link
Contributor Author

ms2008 commented Jul 13, 2023

Please hold off on the merge until 3.4 is sent out. After checking with @teb510, this also needs to be shipped to 3.4.

@ms2008 ms2008 added this to the 3.4.0 milestone Jul 14, 2023
@kikito
Copy link
Member

kikito commented Jul 18, 2023

This was not merged in time for Feature freeze so I have removed it from the milestone. Please get special approval from a director-level person in order to merge this feature before 3.4 GA.

@kikito kikito removed this from the 3.4.0 milestone Jul 18, 2023
@RobSerafini RobSerafini added this to the 3.4.0 milestone Jul 19, 2023
@VicYP
Copy link

VicYP commented Jul 20, 2023

@kikito I see Saju's approval for posting freeze merge for this feature. If this one worth to be added to 3.4. Please review this one asap.

@windmgc windmgc merged commit 3e52664 into master Jul 21, 2023
30 checks passed
@windmgc windmgc deleted the feat/otel-endpoint-referenceable branch July 21, 2023 03:27
team-gateway-bot pushed a commit that referenced this pull request Jul 21, 2023
* feat(opentelemetry): make endpoint field referenceable

* docs(changelog): add an entry to the changelog

(cherry picked from commit 3e52664)
windmgc pushed a commit that referenced this pull request Jul 21, 2023
* feat(opentelemetry): make endpoint field referenceable

* docs(changelog): add an entry to the changelog

(cherry picked from commit 3e52664)
@kikito kikito mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants