fix(hybrid): opentelemetry and zipkin header_type #11686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
backport (to 3.4) to be done manually, please don't add the label. |
samugi
force-pushed
the
fix/hybrid-compat-otel-zipkin
branch
from
43e045b
to
29bb34b
Compare
3 tasks
flrgh
reviewed
Oct 3, 2023
flrgh
reviewed
Oct 3, 2023
flrgh
reviewed
Oct 3, 2023
flrgh
requested changes
Oct 3, 2023
address compatibility for older DPs for the opentelemetry and zipkin configuration option: `header_type` and for zipkin's `default_heder_type`
samugi
force-pushed
the
fix/hybrid-compat-otel-zipkin
branch
from
29bb34b
to
3dd6966
Compare
flrgh
approved these changes
Oct 3, 2023
|
Thanks @samugi. Looks good, and I think I've approved all the downstream PRs of this in case you need more time to get everything in sync. Feel free to merge at your convenience or @ me if you don't have perms to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Address compatibility for older DPs for the opentelemetry and zipkin configuration option:
header_typeand for zipkin'sdefault_heder_typeChecklist
CHANGELOG/unreleased/kongor addingskip-changeloglabel on PR if unnecessary. README.mdFull changelog
Issue reference
KAG-2705