Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): dedicated config processing #11784

Merged
merged 1 commit into from Oct 18, 2023
Merged

feat(core): dedicated config processing #11784

merged 1 commit into from Oct 18, 2023

Conversation

jschmid1
Copy link
Contributor

@jschmid1 jschmid1 commented Oct 18, 2023 •
edited

Summary

  • rename the existing privileged_worker to dedicated_config_processing
  • switch default value from off to on
  • add alias as well as deprecation handling

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix: KAG-2777

@jschmid1 jschmid1 added this to the 3.5.0 milestone Oct 18, 2023
@jschmid1 jschmid1 force-pushed the feat/dedicated_config_processing branch 4 times, most recently from abd0fe5 to 94a1f13 Compare October 18, 2023 13:33
@jschmid1 jschmid1 marked this pull request as ready for review October 18, 2023 14:33
bungle
bungle reviewed Oct 18, 2023
View reviewed changes
kong.conf.default Outdated Show resolved Hide resolved
bungle
bungle approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@bungle bungle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise approved.

@jschmid1
feat(core): dedicated config processing
5249234 
Signed-off-by: Joshua Schmid <jaiks@posteo.de>
@jschmid1 jschmid1 force-pushed the feat/dedicated_config_processing branch from 94a1f13 to 5249234 Compare October 18, 2023 14:39
@jschmid1 jschmid1 merged commit 30d90f3 into master Oct 18, 2023
24 checks passed
@jschmid1 jschmid1 deleted the feat/dedicated_config_processing branch October 18, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshuebner hanshuebner hanshuebner approved these changes

@bungle bungle bungle approved these changes

@kikito kikito Awaiting requested review from kikito

Assignees

@jschmid1 jschmid1

Labels
core/clustering core/configuration core/templates size/M
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jschmid1 @hanshuebner @bungle