Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release/3.5.x] fix(dns): set default dns_no_sync to on #11871

Merged
merged 1 commit into from
Oct 27, 2023
Merged

[Backport release/3.5.x] fix(dns): set default dns_no_sync to on #11871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/kong/fix_dns_enable_dns_no_sync.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
message: The default value of `dns_no_sync` option has been changed to `on`
type: bugfix
scope: Configuration
2 changes: 1 addition & 1 deletion kong.conf.default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1543,7 +1543,7 @@

#dns_error_ttl = 1 # TTL in seconds for error responses.

#dns_no_sync = off # If enabled, then upon a cache-miss every
#dns_no_sync = on # If enabled, then upon a cache-miss every
# request will trigger its own dns query.
# When disabled multiple requests for the
# same name/type will be synchronised to a
Expand Down
2 changes: 1 addition & 1 deletion kong/templates/kong_defaults.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ dns_stale_ttl = 4
dns_cache_size = 10000
dns_not_found_ttl = 30
dns_error_ttl = 1
dns_no_sync = off
dns_no_sync = on

dedicated_config_processing = off
worker_consistency = eventual
Expand Down