Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(tracing): avoid unnecessary creations and garbage-collections of spans (from timers) #12080

Merged
merged 1 commit into from Nov 23, 2023
Merged

perf(tracing): avoid unnecessary creations and garbage-collections of spans (from timers) #12080

merged 1 commit into from Nov 23, 2023

Commits on Nov 22, 2023

  1. perf(tracing): do not create spans in timer phase 

    Before this change timers would generate spans, which means DB and DNS
spans in recurring timers would be continuously generated and
garbage-collected.

This commit checks the exact ngx phase and runs it against a whitelist
to ensure `timer` phase does not generate spans.
    @samugi
    samugi committed Nov 22, 2023
    Copy the full SHA
    dfe0b50 View commit details
    Browse the repository at this point in the history