Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump ngx_wasm_module to 65a0b46fc8cfeed9a4cd16c5982decf6d8c95f5d #12135

Closed
wants to merge 1 commit into from
Closed

chore(deps): bump ngx_wasm_module to 65a0b46fc8cfeed9a4cd16c5982decf6d8c95f5d #12135

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

Changelog ddb3fa8...65a0b46

Compare on GitHub

  • 65a0b46 - chore(util) use 'git fetch --tags' for updating runtimes
  • b51a15f - chore(*) add a .gitattributes file
  • 9959389 - fix(*) resolve a possible segfault in the FFI
  • 8c45ad1 - fix(*) proper filter modules order in dynamic OpenResty builds
  • 33157a8 - feat(proxy-wasm) custom host properties getters/setters
  • 81c703e - docs(*) minor fix for a title level
  • db88b15 - fix(proxy-wasm) free dispatch calls during resume edge-case
  • 5553ae0 - feat(proxy-wasm) strengthen host functions context checks

IMPORTANT: Remember to scan this commit log for updates to Wasmtime/V8/Wasmer and update .requirements manually as needed

@dependabot
chore(deps): bump ngx_wasm_module to 65a0b46fc8cfeed9a4cd16c5982decf6…
6454999 
…d8c95f5d

Changes since ddb3fa8f7cacc81557144cf22706484eabd79a84:

* 65a0b46 - chore(util) use 'git fetch --tags' for updating runtimes
* b51a15f - chore(*) add a .gitattributes file
* 9959389 - fix(*) resolve a possible segfault in the FFI
* 8c45ad1 - fix(*) proper filter modules order in dynamic OpenResty builds
* 33157a8 - feat(proxy-wasm) custom host properties getters/setters
* 81c703e - docs(*) minor fix for a title level
* db88b15 - fix(proxy-wasm) free dispatch calls during resume edge-case
* 5553ae0 - feat(proxy-wasm) strengthen host functions context checks
@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label Nov 30, 2023
@flrgh
Copy link
Contributor

flrgh commented Nov 30, 2023

Need to hold off on merging until I get this running the full test suite.

@hishamhm
Copy link
Contributor

hishamhm commented Dec 4, 2023 •
edited

@flrgh A heads-up to avoid conflicts: #11856 contains a bump to a lower commit (b51a15fc972540e6b8964e2fe1d86ebf67ca53aa). Is there anything still holding that PR from being merged? Let me know if there's anything I can do to help it cross the line.

We've also had a memory bugfix merged into the module on Friday (Kong/ngx_wasm_module#456), so in any case it's probably better to trigger a new bump pointing to 5f9e8d91d7dbf09b1f3eef8675894e40212e59c2 than to use this one.

(We have another incoming fix at if Kong/ngx_wasm_module#457 as well, but it hasn't been merged yet; if that gets in then the Gateway bump should probably pick that one instead).

UPDATE: Kong/ngx_wasm_module#457 got merged, so 8f3fa9506fd74363010999c3ceb36c08384cfb29 is our new best target.

@hishamhm
Copy link
Contributor

hishamhm commented Dec 6, 2023

@flrgh @locao can we close this one and generate a new bump? Also, can the bump be backported to 3.5? There's an upcoming patch release, and in spite of the additions the FFI used by 3.5 hasn't changed, as far as I know.

@flrgh flrgh closed this Dec 6, 2023
@flrgh flrgh deleted the chore/deps-bump-ngx-wasm-module branch December 7, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flrgh flrgh flrgh approved these changes

Assignees
No one assigned
Labels
author/community PRs from the open-source community (not Kong Inc) size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flrgh @hishamhm @team-eng-enablement