chore(response-rl): standarize redis configuration #12302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nowNick
force-pushed
the
chore/standarize-redis-configuration-response-rl
branch
from
40f8533
to
2d67545
Compare
nowNick
force-pushed
the
chore/standarize-redis-configuration-rate-limiting
branch
from
89fc3b0
to
d519f2a
Compare
nowNick
force-pushed
the
chore/standarize-redis-configuration-response-rl
branch
from
2d67545
to
b290eec
Compare
nowNick
force-pushed
the
chore/standarize-redis-configuration-rate-limiting
branch
from
d519f2a
to
0b01009
Compare
This was referenced Jan 8, 2024
nowNick
force-pushed
the
chore/standarize-redis-configuration-rate-limiting
branch
10 times, most recently
from
6523fc1
to
c36ec13
Compare
nowNick
force-pushed
the
chore/standarize-redis-configuration-response-rl
branch
2 times, most recently
from
955cd8b
to
3ef350f
Compare
nowNick
force-pushed
the
chore/standarize-redis-configuration-response-rl
branch
4 times, most recently
from
f572e5d
to
fbfdef2
Compare
nowNick
force-pushed
the
chore/standarize-redis-configuration-rate-limiting
branch
from
c36ec13
to
a877569
Compare
nowNick
force-pushed
the
chore/standarize-redis-configuration-response-rl
branch
from
fbfdef2
to
a6b3bd6
Compare
nowNick
force-pushed
the
chore/standarize-redis-configuration-rate-limiting
branch
from
a877569
to
1ef1dfc
Compare
nowNick
force-pushed
the
chore/standarize-redis-configuration-rate-limiting
branch
from
1ef1dfc
to
e2938a7
Compare
nowNick
force-pushed
the
chore/standarize-redis-configuration-response-rl
branch
from
a6b3bd6
to
3e79e98
Compare
jschmid1
reviewed
Jan 11, 2024
jschmid1
reviewed
Jan 11, 2024
Response-RateLimiting right now has new config structure that reuses common redis connection configuration. The same as ACME and RateLimiting plugin. KAG-3388
nowNick
force-pushed
the
chore/standarize-redis-configuration-response-rl
branch
from
3e79e98
to
6d5f720
Compare
locao
merged this pull request
into
chore/standarize-redis-configuration-rate-limiting
24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Response-RateLimiting right now has new config structure that reuses common redis connection configuration.
Many plugins differ in the way Redis is configured. The goal of this PR is to introduce a standard Redis config schema that could be shared across plugins.
Other PRs
This is the last in the chains of PRs that standardize Redis configuration.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdThere is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HEREIssue reference
KAG-3388