feat(ai-proxy): google-gemini support #12948
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cherry-pick kong-ee
tysoekong
force-pushed
the
feat/ai_proxy_google_gemini
branch
from
7724fc8
to
4c9b05b
Compare
3 tasks
tysoekong
requested review from
locao,
hanshuebner and
jschmid1
and removed request for
jschmid1
tysoekong
changed the title
fffonion
reviewed
Jun 17, 2024
| @@ -0,0 +1,9 @@ | |||
| FROM kong:3.6.1 | |||
fffonion
reviewed
Jun 17, 2024
| end | ||
|
|
||
| local events = ai_shared.frame_to_events(chunk) | ||
| local events = ai_shared.frame_to_events(chunk, conf.model.provider == "gemini") |
There was a problem hiding this comment.
Suggested change
| local events = ai_shared.frame_to_events(chunk, conf.model.provider == "gemini") | |
| local is_raw_json = conf.model.provider == "gemini" | |
| local events = ai_shared.frame_to_events(chunk, is_raw_json ) |
|
|
||
| -- some new LLMs return the JSON object-by-object, | ||
| -- because that totally makes sense to parse?! | ||
| if raw_json_mode then |
There was a problem hiding this comment.
we need some unit tests for this if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Google Gemini support to Kong AI Gateway.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
AG-27