Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block consumer_id for some plugins #322

Closed
subnetmarco opened this issue Jun 10, 2015 · 0 comments
Closed

Block consumer_id for some plugins #322

subnetmarco opened this issue Jun 10, 2015 · 0 comments
Assignees
@thibaultcha
Milestone
0.4.0

Comments

@subnetmarco
Copy link
Member

Currently some plugins, like the SSL Plugin, don't support a customer_id because of technical limitations or because it wouldn't make sense.

Currently we discourage using consumer_id just by not documenting it, but we should have a way to block setting a consumer_id in the API itself returning a message like: "The consumer_id cannot be specified for this plugin".

Should the consumer_id be part of each plugin's schema maybe?
@thibaultcha thibaultcha self-assigned this Jun 29, 2015
thibaultcha added a commit that referenced this issue Jun 30, 2015
@thibaultcha
feat: blocking consumer_id for SSL
8d5e6b6 
Handled with a custom check in SSL's `on_insert` event. Waiting for
global plugins implementation for a cleaner, more generic solution.

Fix #322
@thibaultcha thibaultcha mentioned this issue Jun 30, 2015
Merged
thibaultcha added a commit that referenced this issue Jul 1, 2015
@thibaultcha
feat: blocking consumer_id for SSL
dd9df61 
Handled with a custom check in SSL's `on_insert` event. Waiting for
global plugins implementation for a cleaner, more generic solution.

Fix #322
@thibaultcha thibaultcha added this to the 0.4.0 milestone Jul 1, 2015
ctranxuan pushed a commit to streamdataio/kong that referenced this issue Aug 25, 2015
@thibaultcha
feat: blocking consumer_id for SSL
ddbc43f 
Handled with a custom check in SSL's `on_insert` event. Waiting for
global plugins implementation for a cleaner, more generic solution.

Fix Kong#322


Former-commit-id: cfb6a0b1632e4f412bf168ffd60b52d4d58e80c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thibaultcha thibaultcha

Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
2 participants
@subnetmarco @thibaultcha