refactor(balancer) rename balancer_address to balancer_data #3502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ctx structure for storing balancer data grew over time to store much more than the address. This renaming reflects that. Also tweaked the style of the lines touched by this patch to fit in 80 characters.
thibaultcha
approved these changes
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ctxstructure for storing balancer data grew over time to store much more than the address. This renaming reflects that. Also made the localized versions match the name (thoseaddrlocals that contained non-address data did confuse me back then when I started learning about the balancer!).This also moves
balancer_hash_cookieadded by @PepperTeasdale inside that same structure.Since at least one plugin did access
ngx.ctx.balancer_addressexplicitly, I kept an alias around for backwards compatibility.Also took the opportunity to tweak the style of the lines touched by this patch to make them fit in 80 characters.