feat(core) add kong.resty.getssl module #3681
Conversation
kong/resty/getssl.lua
Outdated
| return pushssl(ptr) | ||
| end | ||
|
|
||
| return { |
There was a problem hiding this comment.
style: please respect the 2 lines jump between logical blocks in this codebase - thanks!
kong/resty/getssl.lua
Outdated
| local get_ssl_pointer = require "ngx.ssl".get_ssl_pointer | ||
|
|
||
| if get_ssl_pointer == nil then | ||
| error("Openresty patch missing. See https://github.com/Kong/openresty-patches") |
There was a problem hiding this comment.
typo: OpenResty
More importantly: we should gracefully fail if the patch is not available, but not prevent the module from loading altogether, which would certainly prevent Kong from even starting; while in fact, this feature might not even be used.
There was a problem hiding this comment.
I'm not sure how this should fail gracefully: if the patch is not applied and you're using this module, then you've likely got a security issue.
We could create a 'dummy' function that always returns nil, "OpenResty patch missing". But would it get checked correctly? I guess that will do for now....
thibaultcha
added
pr/changes requested
This allows fetching the SSL* object for the current client as a luaossl object
james-callahan
force-pushed
the
feat/getssl
branch
from
445e953
to
1880641
Compare
james-callahan
added
pr/please review
and removed
pr/changes requested
Summary
This allows fetching the
SSL*object for the current client as a luaossl object