Feat/groundwork for zipkin #3842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kikito
force-pushed
the
feat/pdk-extensions-for-zipkin
branch
from
82666cf
to
f9137bc
Compare
hishamhm
reviewed
Oct 10, 2018
kikito
force-pushed
the
feat/pdk-extensions-for-zipkin
branch
from
ebbc696
to
4830d28
Compare
hishamhm
reviewed
Oct 16, 2018
kikito
force-pushed
the
feat/pdk-extensions-for-zipkin
branch
from
359f24b
to
2241fbd
Compare
bungle
reviewed
Oct 16, 2018
kong/pdk/request.lua
Outdated
| -- -- Given a request to https://example.com:1234/v1/movies?movie=foo | ||
| -- | ||
| -- kong.request.get_path_and_querystring() -- "/v1/movies?movie=foo" | ||
| function _REQUEST.get_path_and_querystring() |
There was a problem hiding this comment.
I left comment about the name here:
#3859 (review)
kikito
force-pushed
the
feat/pdk-extensions-for-zipkin
branch
from
2241fbd
to
9f2a159
Compare
|
I am not sure if |
kikito
force-pushed
the
feat/pdk-extensions-for-zipkin
branch
from
9f2a159
to
5aa253b
Compare
When the path + querystring is needed, this prevents having to manually check wether the querystring is present and concatenating the path + "?" + the query string every time. Needed for the zipkin plugin.
This came out while reviewing the zipkin plugin. I was not able to reproduce the problem in our tests. It certainly does not hurt to have the extra `or ""` anyway
kikito
force-pushed
the
feat/pdk-extensions-for-zipkin
branch
from
5aa253b
to
5ef4583
Compare
thibaultcha
pushed a commit
that referenced
this pull request
Oct 17, 2018
When the path + querystring is needed, this prevents having to manually check wether the querystring is present and concatenating the path + "?" + the query string every time. From #3842 Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>
thibaultcha
pushed a commit
that referenced
this pull request
Oct 17, 2018
This came out while reviewing the zipkin plugin. I was not able to reproduce the problem in our tests. It certainly does not hurt to have the extra `or ""` anyway. From #3842 Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>
|
Merged to next with adjustments; except for the timing API commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a couple features to the PDK:
kong.request.get_start_time(), which wrapsngx.req.start_time()kong.request.get_raw_path_and_query()It also fix a (possible?) problem when ngx.request_uri is nil.
It is needed for the zipkin update: Kong/kong-plugin-zipkin#24