Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db) support for cassandra 4 #3873

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@gchristidis
Copy link
Contributor

gchristidis commented Oct 19, 2018

Summary

Kong 014.0 fails to start when backed by Datastax Enterprise 6.X with error

could not load routes: [Invalid] table schema_columns does not exist

DSE 6.X reports 4.0.X as the release_version in system.local table. The system schema components used by Kong in 3 are the same in 4 so changes were made such that schema selection based on cassandra major_version assumes future versions use the same schema.

Issues resolved

Fix #3837

fix(db) support for cassandra 4
The schema selection based on cassandra major_version of 3 assumes 
future versions uses the same schema.
Datastax Enterprise 6.X reports release_version in system.local 
table as 4.0.X

Issue #3837
@mprimeaux
Copy link
Contributor

mprimeaux left a comment

I've confirmed this fix works in my environment against the latest version of DataStax Cassandra. Looks good to me.

thibaultcha added a commit that referenced this pull request Oct 22, 2018

fix(db) small tweaks to support DSE 6
The schema selection based on the Cassandra `major_version` now assumes
future versions uses the same schema.

Datastax Enterprise 6.x reports `release_version` in `system.local`
table as 4.0.x.

Fix #3837
From #3873

Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>
@thibaultcha

This comment has been minimized.

Copy link
Member

thibaultcha commented Oct 22, 2018

Thanks! Manually merged with a few minor tweaks (updated a missing location).

@gchristidis gchristidis deleted the gchristidis:fix/cassandra-4 branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.