perf(acl) properly cache intermediary config #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, the `if not config` branch was hit during every request, effectively nullifying the plugin's config cache optimization.
|
I ran a quick check against bundled plugins and no other seem to have the same defect. Please have a look and confirm @Tieske, thanks. |
Tieske
approved these changes
Dec 1, 2018
|
By reusing the pattern for the commit I added to #3872 - noticed we never saved the table. Thanks for taking a look. |
jschmid1
added a commit
to jschmid1/kong
that referenced
this pull request
Nov 17, 2022
remove cache_key from key-sets change cache_key construction of keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, the
if not configbranch was hit during everyrequest, effectively nullifying the plugin's config cache optimization.