Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(acl) properly cache intermediary config #4040

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
2 participants
@thibaultcha
Copy link
Member

commented Dec 1, 2018

Prior to this patch, the if not config branch was hit during every
request, effectively nullifying the plugin's config cache optimization.

perf(acl) properly cache intermediary config
Prior to this patch, the `if not config` branch was hit during every
request, effectively nullifying the plugin's config cache optimization.

@thibaultcha thibaultcha added this to the 1.0.0rc4 milestone Dec 1, 2018

@thibaultcha thibaultcha requested a review from Tieske Dec 1, 2018

@thibaultcha

This comment has been minimized.

Copy link
Member Author

commented Dec 1, 2018

I ran a quick check against bundled plugins and no other seem to have the same defect. Please have a look and confirm @Tieske, thanks.

@Tieske

Tieske approved these changes Dec 1, 2018

Copy link
Member

left a comment

good catch! how did you even find this?

@thibaultcha

This comment has been minimized.

Copy link
Member Author

commented Dec 1, 2018

By reusing the pattern for the commit I added to #3872 - noticed we never saved the table. Thanks for taking a look.

@thibaultcha thibaultcha merged commit 408ce27 into master Dec 3, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla All CLA requirements met.

@thibaultcha thibaultcha deleted the perf/acl-config-cache branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.