chore(deps) update dns lib to 3.0.2 #4386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a potential issue with the healthchecks not being able to set the status of a peer. This happens when there are multiple levels of dns, eg: SRV -> A -> ip-address.
With 2 level (or more) dns records, typically SRV pointing to an A, resolving to an IP, the balancer would not recognize the address to disable because the balancer would hold the name (of the A record) in this case and not match the IP address. To test this scenario a mock for the dns client was required, since it is ran as an integration test. This commit will provide the mock and the failing test
hishamhm
force-pushed
the
fix/healthchecks-next
branch
from
d2882d1
to
1525b3d
Compare
kikito
approved these changes
Mar 13, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.