feat(rate-limiting) add support for Retry-After header on 429 response #5329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
feat/rate-limiting-retry-after
branch
5 times, most recently
from
8a9da5f
to
6323c4e
Compare
hishamhm
reviewed
Dec 13, 2019
bungle
force-pushed
the
feat/rate-limiting-retry-after
branch
from
6323c4e
to
91ca1fb
Compare
bungle
force-pushed
the
feat/rate-limiting-retry-after
branch
from
91ca1fb
to
ec9d3dc
Compare
### Summary This have been previously proposed with #3451 and #2735. This PR tries only to add `Retry-After` header, so it is not as complete as #3451, but it may be easier to get these in as parts. Thank you @grahamar and @ioggstream for all the previous efforts. ### Details The `Retry-After` is in `seconds`. If there is more than one `Limit` configured and more than one limit has exceeded the `Retry-After` will contain the biggest number (in seconds). E.g. if minute limit is exceeded and hour limit is exceeded it probably means that `Retry-After` will tell you when the hour limit is released assuming that the minute limit will be released earlier. The PR is also turning on most of the `unit test` suite on `rate-limiting`.
bungle
force-pushed
the
feat/rate-limiting-retry-after
branch
from
ec9d3dc
to
b70a87e
Compare
This performs the test up to two times (and no more than two). We are **not** retrying to "give it another shot" in case of a flaky test. The reason why we allow for a single retry in this test suite is because tests are dependent on the value of the current minute. If the minute flips during the test (i.e. going from 03:43:59 to 03:44:00), the result will fail. Since each test takes less than a minute to run, running it a second time right after that failure ensures that another flip will not occur. If the second execution failed as well, this means that there was an actual problem detected by the test.
hishamhm
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This have been previously proposed with #3451 and #2735. This PR tries only to add
Retry-Afterheader, so it is not as complete as #3451, but it may be easier to get these in as parts.Thank you @grahamar and @ioggstream for all the previous efforts.
Details
The
Retry-Afteris inseconds. If there is more than oneLimitconfigured and more than one limit has exceeded theRetry-Afterwill contain the biggest number (in seconds). E.g. if minute limit is exceeded and hour limit is exceeded it probably means thatRetry-Afterwill tell you when the hour limit is released assuming that the minute limit will be released earlier.The PR is also turning on most of the
unit testsuite onrate-limiting.