feat(plugins) set generic X-Credential-Identifier #5516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…redential-Username) ### Summary The PR #4993 implemented `X-Credential-Identifier` for `JWT Plugin` and it was decided at time that we should add support for this less opinionated field name on other auth plugins too. This commit adds it to `Basic Auth Plugin`.
bungle
changed the title
dndx
reviewed
Feb 3, 2020
…dential-Username) ### Summary The PR #4993 implemented `X-Credential-Identifier` for `JWT Plugin` and it was decided at time that we should add support for this less opinionated field name on other auth plugins too. This commit adds it to `Key Auth Plugin`.
…edential-Username) ### Summary The PR #4993 implemented `X-Credential-Identifier` for `JWT Plugin` and it was decided at time that we should add support for this less opinionated field name on other auth plugins too. This commit adds it to `HMAC Auth Plugin`.
…edential-Username) ### Summary The PR #4993 implemented `X-Credential-Identifier` for `JWT Plugin` and it was decided at time that we should add support for this less opinionated field name on other auth plugins too. This commit adds it to `LDAP Auth Plugin`.
…ntial-Username) ### Summary The PR #4993 implemented `X-Credential-Identifier` for `JWT Plugin` and it was decided at time that we should add support for this less opinionated field name on other auth plugins too. This commit adds it to `OAuth2 Plugin`. This feature was originally implemented by @lucasmoreno on PR #5201. Thank you, Lucas, grab your T-shirt: https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#contributor-t-shirt! I just refactored @lucasmoreno's code to use our generic `X-Credential-Identifier` header instead of the proposed `X-Credential-Client-Id`. ### Issues Resolved Closes #5201
### Summary Updates `JWT Plugin's` `set_consumer` function to be consistent with other auth plugins.
### Summary Right now some plugins that used to set `X-Credential-Username` are now also setting `X-Credential-Identifier` with the same value. We want to get rid of `X-Credential-Username` at some point in favor for `X-Credential-Identifier`. This commit just adds a TODO comment there.
bungle
force-pushed
the
feat/credential-identifier
branch
from
f21de94
to
20e125c
Compare
dndx
approved these changes
Feb 3, 2020
This was referenced May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR #4993 implemented
X-Credential-IdentifierforJWT Pluginand it was decidedat time that we should add support for this less opinionated field name on other auth
plugins too. This commit adds it to other bundled auth plugins too:
It also adds two more commits:
This PR makes
set_consumerconsistent on all the bundled auth plugins.Issues Resolved
This PR closes the PR #5201 by @lucasmoreno (only difference being more tests added and header name changed to Kong generic
X-Credential-Identifier. Thanks @lucasmoreno, grab your contributor T-shirt at here: https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#contributor-t-shirt (you can link to this PR).