fix(schema) more descriptive error logs when type is invalid #6593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
fix/schema-more-descriptive-error-messages
branch
2 times, most recently
from
fa06a9e
to
d6e7be5
Compare
|
One thing about this is that should we check if the input is valid |
bungle
force-pushed
the
fix/schema-more-descriptive-error-messages
branch
from
d6e7be5
to
2f60c66
Compare
bungle
force-pushed
the
fix/schema-more-descriptive-error-messages
branch
from
2f60c66
to
965ca1c
Compare
kikito
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I screwed, sorry @WALL-E, I tried to rebase your original: #6400, but then mistakenly pushes next branch to your next branch, while I was meaning to push the rebased one. Then it closed the PR and I could not push anymore to your branch, Thus here it is again. If this goes green I think we can merge it. Thank you @WALL-E and sorry for inconvenience.