fix(utils) accept hosts ending in dots #6864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locao
force-pushed
the
fix/fqdn_ending_in_dots
branch
from
f85591b
to
14710da
Compare
kikito
approved these changes
Feb 24, 2021
gszr
previously requested changes
Mar 4, 2021
locao
force-pushed
the
fix/fqdn_ending_in_dots
branch
from
14710da
to
6cddf78
Compare
locao
force-pushed
the
fix/fqdn_ending_in_dots
branch
from
6cddf78
to
8fcaad0
Compare
|
imo, the lib only had a bugfix, so |
gszr
dismissed
their stale review
discussed with the team, let's go ahead with the bump in master
According to https://tools.ietf.org/html/rfc3986#section-3.2.2 hosts can end in dots
locao
force-pushed
the
fix/fqdn_ending_in_dots
branch
from
8fcaad0
to
199f067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 3986 - section 3.2.2 hosts can end in dots
Kong/lua-resty-dns-client#122 is a sister PR and this one should not be merged before the
lua-resty-dns-clientrelease with that fix included.