fix(go) - go-pluginserve config #6981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
two related issues: - the new config style is detected by the `pluginserver_names` setting, but the default is an empty table, thus it's never falsy, and the old configuration style is never attempted - the pluginserver names serve to tie the other configuration fields, but those fieldnames are lowercased, so the pluginserver names must be lowered too.
kikito
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two related issues:
the new config style is detected by the
pluginserver_namessetting,but the default is an empty table, thus it's never falsy, and the old
configuration style is never attempted
the pluginserver names serve to tie the other configuration fields,
but those fieldnames are lowercased, so the pluginserver names must be
lowered too.
Fix #6840