fix(external-plugins) response.getXXX() functions from log phase #7048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierguerragiraldez
force-pushed
the
fix/response-data-after-log
branch
from
0071964
to
4e4e1ed
Compare
The `kong.response.get_XXX()` functions require data from the response object, which is no longer accessible in the "post-log" timer used to call Log handlers in external plugins. This patch allows those functions to work by adding the required data to the set saved at the start of the "real" log phase.
locao
force-pushed
the
fix/response-data-after-log
branch
from
4e4e1ed
to
68ac60b
Compare
The only difference is that under MessagePack, headers and decoded query results must be "fixed" to get the right MP structure.
javierguerragiraldez
force-pushed
the
fix/response-data-after-log
branch
from
68ac60b
to
39d0d36
Compare
dndx
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
kong.response.get_XXX()functions require data from the responseobject, which is no longer accessible in the "post-log" timer used to
call Log handlers in external plugins.
This patch allows those functions to work by adding the required data to
the set saved at the start of the "real" log phase.
Fix Kong/go-pdk#61