fix(declarative) yaml anchors were not properly processed #7748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
fix/7620-yaml-anchors
branch
from
4a73683
to
8a7c2df
Compare
gszr
approved these changes
Aug 25, 2021
dndx
approved these changes
Aug 25, 2021
### Summary The `lyaml` is used to parse the YAML input. When YAML anchors are used the library optimizes decoding by reusing referenced table. Our generate ids procedure did not take that in the account as explained on issue #7620 by @bforbis. So we ended up inserting the item with same id on SHM on import. And that could also be seen from admin api where it only listed the entity once instead of as many times as it has been used and referenced. ### Issues Resolved Fix #7620
bungle
force-pushed
the
fix/7620-yaml-anchors
branch
2 times, most recently
from
0cc668e
to
1cb4f5a
Compare
kikito
pushed a commit
that referenced
this pull request
Aug 31, 2021
### Summary The `lyaml` is used to parse the YAML input. When YAML anchors are used the library optimizes decoding by reusing referenced table. Our generate ids procedure did not take that in the account as explained on issue #7620 by @bforbis. So we ended up inserting the item with same id on SHM on import. And that could also be seen from admin api where it only listed the entity once instead of as many times as it has been used and referenced. ### Issues Resolved Fix #7620
javierguerragiraldez
pushed a commit
that referenced
this pull request
Sep 2, 2021
### Summary The `lyaml` is used to parse the YAML input. When YAML anchors are used the library optimizes decoding by reusing referenced table. Our generate ids procedure did not take that in the account as explained on issue #7620 by @bforbis. So we ended up inserting the item with same id on SHM on import. And that could also be seen from admin api where it only listed the entity once instead of as many times as it has been used and referenced. ### Issues Resolved Fix #7620 (cherry picked from commit 08f9f4e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
lyamlis used to parse the YAML input. When YAML anchors are used the library optimizes decoding by reusing referenced table. Our generate ids procedure did not take that in the account as explained on issue #7620 by @bforbis. So we ended up inserting the item with same id on SHM on import. And that could also be seen from admin api where it only listed the entity once instead of as many times as it has been used and referenced.Issues Resolved
Fix #7620