fix(prometheus) add subsystem label to upstream's health info #7802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gszr
force-pushed
the
fix/prometheus-health-subsystem-label
branch
from
c50c5f0
to
e3480cc
Compare
fffonion
reviewed
Sep 3, 2021
gszr
force-pushed
the
fix/prometheus-health-subsystem-label
branch
from
e3480cc
to
c319a41
Compare
fffonion
approved these changes
Sep 3, 2021
|
The motivation for this PR is to disambiguate the health metrics for stream and HTTP subsystems -- in this sense, it could be seen as a "fix", as the old behavior causes confusion. However, it's adding a new label, so I am hesitant to give it a "fix" scope. |
|
I think a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure upstream's targets health metrics has an
upstreamlabel to indicate which upstream that metric originates.