fix(router) remove last dot in FQDNs #8269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a route has an SNI attribute containing an FQDN ending in a dot, the trailing dot was being used to match routes. But according to RFC-3546, this trailing dot is not part of the hostname, thus must not be used for matching.
This change updates the route marshaling function to not include the trailing dot in this case.
Full changelog
Issue reference
Fix #7550
CT-236