Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core) rpc handling of cjson.null #8611

Merged
merged 5 commits into from
Apr 6, 2022
Merged

fix(core) rpc handling of cjson.null #8611

merged 5 commits into from
Apr 6, 2022

Conversation

StarlightIbuki
Copy link
Contributor

RPC(msgpack) did not recongnize cjson.null(userdata NULL).
Patch to make it compatible with cjson.

Fix #8610

@StarlightIbuki
fix(core) rpc handling cjson.null
9fb8eec 
RPC(msgpack) did not recongnize cjson.null(userdata NULL).
Patch to make it compatible with cjson.

fix #8610
kikito
kikito previously requested changes Mar 30, 2022
View reviewed changes
Copy link
Member

@kikito kikito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks ok to me, but needs two more changes:

  • One test
  • An entry in the changelog, on the Fixes section.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 1, 2022
@pull-request-size pull-request-size bot added size/S and removed size/M labels Apr 6, 2022
@bungle bungle dismissed kikito’s stale review April 6, 2022 09:38

things were added

@kikito kikito merged commit 973de1e into master Apr 6, 2022
@kikito kikito deleted the fix/msgpack_json_null branch April 6, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffonion fffonion fffonion left review comments

@kikito kikito kikito approved these changes

@bungle bungle bungle approved these changes

@javierguerragiraldez javierguerragiraldez Awaiting requested review from javierguerragiraldez

Assignees
No one assigned
Labels
core/docs core/language/go core/language/js core/language/python size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using getBody and sending a JSON payload with null values causes error
4 participants
@StarlightIbuki @kikito @bungle @fffonion