Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config cache #8704

Merged
merged 3 commits into from
May 25, 2022
Merged

Remove config cache #8704

merged 3 commits into from
May 25, 2022

Conversation

aboudreault
Copy link
Contributor

@aboudreault aboudreault commented Apr 20, 2022

The data plane configuration is now persisted on disk with the LMDB database. At startup,
the node automatically reload the latest version of the configuration. The config cache mechanism is not useful
anymore.

Do not merge, depends on: #8670

@@ -93,6 +93,7 @@

- Change the default of `lua_ssl_trusted_certificate` to `system`
[#8602](https://github.com/Kong/kong/pull/8602) to automatically load trusted CA list from system CA store.
- `data_plane_config_cache_mode` and `data_plane_config_cache_path` were removed [#8704](https://github.com/Kong/kong/pull/8704).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data plane config cache mechanism and its related configuration options have been removed (data_plane_config_cache_mode and data_plane_config_cache_path) The config cache is now automatically persisted on disk with LMDB. With this change, #8704.

@aboudreault aboudreault added this to the 3.0 milestone May 5, 2022
@aboudreault aboudreault added the pr/ready This PR is considered ready and can be merged at anytime (given it received no subsequent changes) label May 12, 2022
@fffonion
Copy link
Contributor

@aboudreault do we have a EE sister PR for this?

@aboudreault
Copy link
Contributor Author

@fffonion not yet. my plan is that when #8670 and #8704 are merged, I will do a CE->EE merge and open the sister EE PR.

@guanlan guanlan requested a review from bungle May 25, 2022 13:29
@aboudreault aboudreault requested a review from a team as a code owner May 25, 2022 13:46
Base automatically changed from feat/dbless-persistence to master May 25, 2022 14:04
@aboudreault aboudreault force-pushed the chore/remove-config-cache branch 2 times, most recently from d70f0ef to 3ce3231 Compare May 25, 2022 18:39
The data plane configuration is now persisted on disk with the LMDB database. At startup,
the node automatically reload the latest version of the configuration. The config cache mechanism is not useful
anymore.
@aboudreault aboudreault merged commit 17aa04e into master May 25, 2022
@aboudreault aboudreault deleted the chore/remove-config-cache branch May 25, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog core/clustering pr/ready This PR is considered ready and can be merged at anytime (given it received no subsequent changes) size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants