fix(language) plugin server graceful shutdown #8923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we exit or reload kong, plugin servers are quiting because they encounter error in socket. This behavior is not proper. We not close with SIGTERM when possible. Hopefully this can be a fix to #8531
|
I'm not sure about the original behavior. Please do not merge now. |
StarlightIbuki
added
the
pr/ready (but hold merge)
javierguerragiraldez
approved these changes
Jun 10, 2022
aboudreault
approved these changes
Jun 10, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we exit or reload kong, plugin servers are quitting because they encounter errors in the socket(closing). This behavior is not proper. We close with SIGTERM when possible.
Hopefully, this can be a fix to #8531