fix(request-termination): status_code cannot be set as null #9400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronolaw
reviewed
Oct 13, 2022
| @@ -1,5 +1,6 @@ | |||
| local schema_def = require "kong.plugins.request-termination.schema" | |||
| local v = require("spec.helpers").validate_plugin_config_schema | |||
| local null = ngx.null | |||
There was a problem hiding this comment.
It seems that this localization is unnecessary.
There was a problem hiding this comment.
It will be used in this line
There was a problem hiding this comment.
Sorry, my meaning is that we can use ngx.null in this line, need not to localize it.
There was a problem hiding this comment.
I don't think it matters as it seems like a trivial style.🙂
samugi
approved these changes
Oct 13, 2022
dndx
approved these changes
Oct 18, 2022
dndx
force-pushed
the
fix/request-termination
branch
from
0ee88ee
to
22b7f63
Compare
bungle
force-pushed
the
fix/request-termination
branch
from
22b7f63
to
fccf89a
Compare
bungle
changed the title
|
@dndx Please hit the merge button. |
dndx
force-pushed
the
fix/request-termination
branch
from
a664ee7
to
e49e249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
status_codeshould not be allowed to be set to null, otherwise a 500 error will be returned.Full changelog
status_codeas nullFTI-4291