Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pdk): response.exit accept bytes #9526

Merged
merged 3 commits into from
Oct 24, 2022
Merged

fix(pdk): response.exit accept bytes #9526

merged 3 commits into from
Oct 24, 2022

Conversation

StarlightIbuki
Copy link
Contributor

@StarlightIbuki StarlightIbuki commented Oct 11, 2022 •
edited by bungle
Loading

fix #9294

@StarlightIbuki StarlightIbuki requested a review from a team as a code owner October 11, 2022 07:33
@chronolaw chronolaw linked an issue Oct 11, 2022 that may be closed by this pull request
ExitArgs.Body should be []byte instead of string #9294
Closed
1 task
@fffonion
Copy link
Contributor

as we are doing this, could you also update for SetRawBody and GetRawBody as well?

@chronolaw
Copy link
Contributor

Do not forget to add change log entry.

@StarlightIbuki StarlightIbuki marked this pull request as draft October 17, 2022 02:47
@StarlightIbuki
Copy link
Contributor Author

Technically, Ctx_GetShared can return raw binary strings, and Ctx_SetShared can accept raw binary strings. But we are ignoring them for now.

@StarlightIbuki StarlightIbuki marked this pull request as ready for review October 19, 2022 08:57
@StarlightIbuki
Copy link
Contributor Author

Maybe we should be more specific about the version that will be incompatible, but we need to merge the PR Kong/go-pdk#132 first, and that PR is waiting for this PR to merge...

chronolaw
chronolaw reviewed Oct 20, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@StarlightIbuki StarlightIbuki mentioned this pull request Oct 24, 2022
Merged
@fffonion fffonion merged commit cd2bcf9 into master Oct 24, 2022
@fffonion fffonion deleted the fix/go-pdk/response_exit branch October 24, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw left review comments

@fffonion fffonion fffonion approved these changes

Assignees
No one assigned
Labels
changelog core/language/go core/language/js core/language/python size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExitArgs.Body should be []byte instead of string
3 participants
@StarlightIbuki @fffonion @chronolaw