feat(core): add keys and key-sets entity #9737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschmid1
force-pushed
the
feat/keys
branch
10 times, most recently
from
cf8b2b7
to
a635c5b
Compare
bungle
reviewed
Nov 15, 2022
bungle
reviewed
Nov 15, 2022
bungle
reviewed
Nov 15, 2022
kikito
reviewed
Nov 15, 2022
Comment on lines
+11
to
+13
| function key_sets:truncate() | ||
| return self.super.truncate(self) | ||
| end |
There was a problem hiding this comment.
Why do we need all the method redefinitions on this file (and on keys)?
There was a problem hiding this comment.
A matter of taste I guess. Some of the methods are generated based on presence of certain entity fields. Explicitly defining the methods, even if these are just a pass-through, helps with understanding the functionality that this dao provides.
flrgh
reviewed
Nov 15, 2022
flrgh
reviewed
Nov 15, 2022
flrgh
reviewed
Nov 15, 2022
flrgh
reviewed
Nov 15, 2022
flrgh
reviewed
Nov 15, 2022
Signed-off-by: Joshua Schmid <jaiks@posteo.de>
javierguerragiraldez
added a commit
to Kong/koko
that referenced
this pull request
Dec 20, 2022
counterpart to Kong/kong#9737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes: #9677
This is ready for a first round of reviews.
Summary
This PR adds support for managing asymmetric keys in various formats (JWK, PEM). It adds two new entities
that accept the mentioned formats.
Full changelog
Missing things:
or skip tests for itSigned-off-by: Joshua Schmid jaiks@posteo.de