fix(declarative-config): set hash when config is loaded #9911
Conversation
kong/db/declarative/init.lua
Outdated
| @@ -660,6 +660,11 @@ end | |||
| declarative.unique_field_key = unique_field_key | |||
|
|
|||
|
|
|||
| local function config_is_empty(entities) | |||
| -- empty configuration has no entries other than workspaces | |||
| return entities["workspaces"] and tablex.size(entities) == 1 | |||
There was a problem hiding this comment.
You can use https://github.com/openresty/luajit2#tablenkeys for tablex.size. Might be faster for large configs.
Also, do we need to do and entities.workspace just to be safe? I'm not sure if it is possible to have an entities that has not workspace or will it always be added by the parser.
There was a problem hiding this comment.
You can use https://github.com/openresty/luajit2#tablenkeys for tablex.size. Might be faster for large configs.
Done, thanks!
do we need to do and entities.workspace just to be safe?
Do you mean the entities["workspaces"] check in my return statement above? That should be always populated here:
kong/kong/db/declarative/init.lua
Line 254 in 2b8d444
|
Due to #9890, we should rebase this PR. |
Ensure the configuration hash field is correctly configured when the declarative configuration is loaded on startup.
ensure the default (empty) config returns the appropriate hash that identifies the empty configuration: 00000000000000000000000000000000
thank you @chronolaw, done. |
Ensure the
hashfield is correctly configured when the declarative configuration is loaded.