-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kdropdownitem): attribute handling #2157
base: alpha
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
359e2a1
to
2ea1ded
Compare
Preview package from this PR in consuming applicationIn consuming application project install preview version of kongponents generated by this PR:
|
import type { DropdownItem, DropdownItemRenderedRecord, DropdownItemRenderedType, DropdownItemType } from '@/types' | ||
import type { PropType } from 'vue' | ||
import { computed, useAttrs } from 'vue' | ||
|
||
export default { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: if you need this you can use defineOptions
Summary
Bind attributes to underlying
.dropdown-item-trigger
instead of wrapperli
element inKDropdownItem
PR Checklist