fix(kdropdownitem): attribute handling #2157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamdehaven
reviewed
Apr 24, 2024
kaiarrowood
reviewed
Apr 24, 2024
adamdehaven
force-pushed
the
alpha
branch
2 times, most recently
from
359e2a1
to
2ea1ded
Compare
Preview package from this PR in consuming applicationIn consuming application project install preview version of kongponents generated by this PR: |
adamdehaven
reviewed
Jun 19, 2024
| import type { DropdownItem, DropdownItemRenderedRecord, DropdownItemRenderedType, DropdownItemType } from '@/types' | ||
| import type { PropType } from 'vue' | ||
| import { computed, useAttrs } from 'vue' | ||
|
|
||
| export default { |
There was a problem hiding this comment.
suggestion: if you need this you can use defineOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bind attributes to underlying
.dropdown-item-triggerinstead of wrapperlielement inKDropdownItemPR Checklist