Skip to content

Commit

Permalink
pr: update additional tests
Browse files Browse the repository at this point in the history
  • Loading branch information
rainest committed Sep 8, 2023
1 parent a728d06 commit 375f3b9
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
7 changes: 6 additions & 1 deletion test/integration/tcpingress_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ var (
)

func TestTCPIngressEssentials(t *testing.T) {
RunWhenKongExpressionRouterWithVersion(t, ">=3.4.0")
ctx := context.Background()

t.Parallel()
Expand Down Expand Up @@ -142,7 +143,7 @@ func TestTCPIngressEssentials(t *testing.T) {
}

func TestTCPIngressTLS(t *testing.T) {
skipTestForExpressionRouter(t)
RunWhenKongExpressionRouterWithVersion(t, ">=3.4.0")
t.Parallel()

t.Log("locking Gateway TLS ports")
Expand Down Expand Up @@ -304,6 +305,10 @@ func TestTCPIngressTLS(t *testing.T) {
func TestTCPIngressTLSPassthrough(t *testing.T) {
t.Parallel()
skipTestForExpressionRouter(t)
// TODO https://github.com/Kong/kubernetes-ingress-controller/issues/4540
// Kong does not currently recognize these requests even though the expression looks correct. This should be enabled
// after determining why the gateway is discarding these requests and applying any necessary fixes.
// RunWhenKongExpressionRouterWithVersion(t, ">=3.4.0")

RunWhenKongVersion(t, fmt.Sprintf(">=%s", versions.TLSPassthroughCutoff))

Expand Down
3 changes: 2 additions & 1 deletion test/integration/udpingress_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ var udpMutex sync.Mutex
const coreDNSImage = "registry.k8s.io/coredns/coredns:v1.8.6"

func TestUDPIngressEssentials(t *testing.T) {
RunWhenKongExpressionRouterWithVersion(t, ">=3.4.0")
t.Parallel()

// Ensure no other UDP tests run concurrently to avoid fights over the port
Expand Down Expand Up @@ -155,7 +156,7 @@ func TestUDPIngressEssentials(t *testing.T) {
}

func TestUDPIngressTCPIngressCollision(t *testing.T) {
skipTestForExpressionRouter(t)
RunWhenKongExpressionRouterWithVersion(t, ">=3.4.0")
t.Parallel()

t.Log("locking TCP and UDP ports")
Expand Down

0 comments on commit 375f3b9

Please sign in to comment.