Skip to content

Commit

Permalink
address review
Browse files Browse the repository at this point in the history
  • Loading branch information
czeslavo committed Oct 9, 2023
1 parent f8e5d1d commit 8112150
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ debug.skaffold:
#
# To make it work with Konnect, you must provide following files under ./config/variants/konnect/debug:
# * `konnect.env` with CONTROLLER_KONNECT_CONTROL_PLANE_ID env variable set
# to the UUID of a Runtime Group you have created in Konnect.
# to the UUID of a Control Plane you have created in Konnect.
# * `tls.crt` and `tls.key` with TLS client cerificate and its key (generated by Konnect).
.PHONY: debug.skaffold.konnect
debug.skaffold.konnect:
Expand Down
2 changes: 1 addition & 1 deletion internal/manager/config_validation.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func (c *Config) validateKonnect() error {
return errors.New("address not specified")
}
if konnect.ControlPlaneID == "" {
return errors.New("runtime group not specified")
return errors.New("control plane not specified")
}
if konnect.TLSClient.IsZero() {
return fmt.Errorf("missing TLS client configuration")
Expand Down
2 changes: 1 addition & 1 deletion internal/manager/config_validation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ func TestConfigValidate(t *testing.T) {
t.Run("enabled with no runtime group is rejected", func(t *testing.T) {
c := validEnabled()
c.Konnect.ControlPlaneID = ""
require.ErrorContains(t, c.Validate(), "runtime group not specified")
require.ErrorContains(t, c.Validate(), "control plane not specified")
})

t.Run("enabled with no address is rejected", func(t *testing.T) {
Expand Down

0 comments on commit 8112150

Please sign in to comment.