fix notify status

internal/dataplane/kong_client.go

@@ -413,24 +413,27 @@ func (c *KongClient) Update(ctx context.Context) error {
 		formatVersion = "3.0"
 	}
 
-	configStatus := ConfigStatusOK
-	defer c.configStatusNotifier.NotifyConfigStatus(configStatus)
+	configStatus := new(ConfigStatus)
+	*configStatus = ConfigStatusOK
+	defer func(status *ConfigStatus) {
+		c.configStatusNotifier.NotifyConfigStatus(*status)
+	}(configStatus)
 
 	// parse the Kubernetes objects from the storer into Kong configuration
 	kongstate, translationFailures := p.Build()
 	if failuresCount := len(translationFailures); failuresCount > 0 {
 		c.prometheusMetrics.RecordTranslationFailure()
 		c.recordResourceFailureEvents(translationFailures, KongConfigurationTranslationFailedEventReason)
 		c.logger.Debugf("%d translation failures have occurred when building data-plane configuration", failuresCount)
-		configStatus = ConfigStatusTranslationErrorHappened
+		*configStatus = ConfigStatusTranslationErrorHappened
 	} else {
 		c.prometheusMetrics.RecordTranslationSuccess()
 		c.logger.Debug("successfully built data-plane configuration")
 	}
 
 	shas, err := c.sendOutToClients(ctx, kongstate, formatVersion, c.kongConfig)
 	if err != nil {
-		configStatus = ConfigStatusApplyFailed
+		*configStatus = ConfigStatusApplyFailed
 		return err
 	}
 

internal/konnect/node_agent.go

@@ -17,6 +17,7 @@ const (
 	NodeOutdateInterval      = 5 * time.Minute
 )
 
+// ConfigStatusSubscriber subscribes status of configuring kong.
 // REVIEW: define the subscriber here, or internal/adminapi for common usage?
 type ConfigStatusSubscriber interface {
 	Subscribe() chan dataplane.ConfigStatus
@@ -110,7 +111,7 @@ func (a *NodeAgent) clearOutdatedNodes() error {
 			// nodes to remove:
 			// (1) since only one KIC node is allowed in a runtime group, all the nodes with other hostnames are considered outdated.
 			// (2) in some cases(kind/minikube restart), rebuilt pod uses the same name. So nodes updated for >5mins before should be deleted.
-			if node.Hostname != a.Hostname || time.Now().Sub(time.Unix(node.UpdatedAt, 0)) > NodeOutdateInterval {
+			if node.Hostname != a.Hostname || time.Since(time.Unix(node.UpdatedAt, 0)) > NodeOutdateInterval {
 				deleteNode = true
 			}
 		}

internal/manager/run.go

@@ -211,7 +211,8 @@ func Run(ctx context.Context, c *Config, diagnostic util.ConfigDumpDiagnostic, d
 				c.Konnect.RefreshNodePeriod,
 				setupLog,
 				konnectNodeAPIClient,
-				configStatusSubscriber)
+				configStatusSubscriber,
+			)
 			agent.Run(ctx)
 		}
 	}