Skip to content

Commit

Permalink
chore: graduate feature gate FillIDs to Beta and set to true by default
Browse files Browse the repository at this point in the history
  • Loading branch information
programmer04 committed Sep 27, 2023
1 parent 95b0447 commit 9e2846c
Show file tree
Hide file tree
Showing 41 changed files with 102 additions and 22 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/_integration_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,10 @@ jobs:
router-flavor: "expressions"
- name: dbless-fill-ids
test: dbless
feature_gates: "GatewayAlpha=true,FillIDs=true"
feature_gates: "GatewayAlpha=true"
- name: postgres-fill-ids
test: postgres
feature_gates: "GatewayAlpha=true,FillIDs=true"
feature_gates: "GatewayAlpha=true"
- name: dbless-rewrite-uris
test: dbless
feature_gates: "GatewayAlpha=true,RewriteURIs=true"
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,12 @@ Adding a new version? You'll need three changes:
- No more "log.SetLogger(...) was never called..." log entry during shutdown of KIC
[#4738](https://github.com/Kong/kubernetes-ingress-controller/pull/4738)

### Added

- The `FillIDs` feature gate is now enabled by default.
[#4746](https://github.com/Kong/kubernetes-ingress-controller/pull/4746)


## 2.12.0

> Release date: 2023-09-25
Expand Down
1 change: 1 addition & 0 deletions FEATURE_GATES.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ Features that reach GA and over time become stable will be removed from this tab
| CombinedServices | `false` | Alpha | 2.10.0 | 3.0.0 |
| CombinedServices | `true` | Beta | 2.11.0 | 3.0.0 |
| FillIDs | `false` | Alpha | 2.10.0 | 3.0.0 |
| FillIDs | `true` | Beta | 3.0.0 | TBD |
| RewriteURIs | `false` | Alpha | 2.12.0 | TBD |

**NOTE**: The `Gateway` feature gate refers to [Gateway
Expand Down
6 changes: 3 additions & 3 deletions internal/dataplane/parser/parser_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5080,12 +5080,12 @@ func TestNewFeatureFlags(t *testing.T) {
},
},
{
name: "fill ids enabled",
name: "fill ids disabled",
featureGates: map[string]bool{
featuregates.FillIDsFeature: true,
featuregates.FillIDsFeature: false,
},
expectedFeatureFlags: FeatureFlags{
FillIDs: true,
FillIDs: false,
},
},
}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 9e2846c

Please sign in to comment.