chore: graduate feature gate FillIDs to Beta and set to true by default

.github/workflows/_integration_tests.yaml

@@ -74,10 +74,10 @@ jobs:
             router-flavor: "expressions"
           - name: dbless-fill-ids
             test: dbless
-            feature_gates: "GatewayAlpha=true,FillIDs=true"
+            feature_gates: "GatewayAlpha=true"
           - name: postgres-fill-ids
             test: postgres
-            feature_gates: "GatewayAlpha=true,FillIDs=true"
+            feature_gates: "GatewayAlpha=true"
           - name: dbless-rewrite-uris
             test: dbless
             feature_gates: "GatewayAlpha=true,RewriteURIs=true"

CHANGELOG.md

@@ -87,6 +87,11 @@ Adding a new version? You'll need three changes:
 - No more "log.SetLogger(...) was never called..." log entry during shutdown of KIC
   [#4738](https://github.com/Kong/kubernetes-ingress-controller/pull/4738)
 
+### Added
+
+- The `FillIDs` feature gate is now enabled by default.
+
+
 ## 2.12.0
 
 > Release date: 2023-09-25

FEATURE_GATES.md

@@ -66,6 +66,7 @@ Features that reach GA and over time become stable will be removed from this tab
 | CombinedServices | `false` | Alpha | 2.10.0  | 3.0.0 |
 | CombinedServices | `true`  | Beta  | 2.11.0  | 3.0.0 |
 | FillIDs          | `false` | Alpha | 2.10.0  | 3.0.0 |
+| FillIDs          | `true`  | Beta  | 3.0.0   | TBD   |
 | RewriteURIs      | `false` | Alpha | 2.12.0  | TBD   |
 
 **NOTE**: The `Gateway` feature gate refers to [Gateway

internal/dataplane/parser/parser_test.go

@@ -5080,12 +5080,12 @@ func TestNewFeatureFlags(t *testing.T) {
 			},
 		},
 		{
-			name: "fill ids enabled",
+			name: "fill ids disabled",
 			featureGates: map[string]bool{
-				featuregates.FillIDsFeature: true,
+				featuregates.FillIDsFeature: false,
 			},
 			expectedFeatureFlags: FeatureFlags{
-				FillIDs: true,
+				FillIDs: false,
 			},
 		},
 	}

internal/manager/featuregates/feature_gates.go

@@ -80,7 +80,7 @@ func GetFeatureGatesDefaults() map[string]bool {
 		GatewayAlphaFeature:     false,
 		CombinedRoutesFeature:   true,
 		ExpressionRoutesFeature: false,
-		FillIDsFeature:          false,
+		FillIDsFeature:          true,
 		RewriteURIsFeature:      false,
 	}
 }

test/e2e/upgrade_test.go

@@ -42,19 +42,6 @@ func TestDeployAndUpgradeAllInOnePostgres(t *testing.T) {
 	})
 }
 
-func TestDeployAndUpgradeAllInOnePostgres_FeatureGates(t *testing.T) {
-	testManifestsUpgrade(t, manifestsUpgradeTestParams{
-		fromManifestURL:   fmt.Sprintf(postgresURLTemplate, upgradeTestFromTag),
-		toManifestPath:    postgresPath,
-		beforeUpgradeHook: postgresBeforeUpgradeHook,
-		// We want to test that nothing breaks when enabling FillIDs feature gate to prevent regressions like
-		// https://github.com/Kong/kubernetes-ingress-controller/issues/4025.
-		// In 2.10.0 this is disabled by default, so we need a separate test for this.
-		// TODO: remove this test when FillIDs is enabled by default.
-		controllerFeatureGates: "FillIDs=true",
-	})
-}
-
 func postgresBeforeUpgradeHook(ctx context.Context, t *testing.T, env environments.Environment) {
 	// Injecting a beforeUpgradeHook to delete the old migrations job before the upgrade. This is necessary because it's
 	// not allowed to modify the existing job's spec.

test/envtest/telemetry_test.go

@@ -355,7 +355,7 @@ func verifyTelemetryReport(t *testing.T, k8sVersion *version.Info, report string
 			"db=off;"+
 			"feature-combinedroutes=true;"+
 			"feature-expressionroutes=false;"+
-			"feature-fillids=false;"+
+			"feature-fillids=true;"+
 			"feature-gateway-service-discovery=false;"+
 			"feature-gateway=false;"+
 			"feature-gatewayalpha=false;"+