You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Although the controller's logger doesn't make use of the --stderrthreshold flag, its client-go instance uses klog and does. However, Cobra doesn't play nicely with it; we need to figure out how to make it handle the klog flags properly.
The text was updated successfully, but these errors were encountered:
$ ./bin/manager --help
flag redefined: kubeconfig
panic: flag redefined: kubeconfig
Removing our kubeconfig definition still overwrites Cobra's generated help with the klog flag set's help, and I'm not sure how we pull out the kubeconfig flag for use with controller-runtime init :(
After reading through this and given the complexities and cost-benefit considering that we've moved away from the previous logging mechanisms that employed this, I have opted to deprecate the flag but make it available for compatibility reasons in 2.0 #1512
Follow up from #1294 (review)
Although the controller's logger doesn't make use of the
--stderrthreshold
flag, its client-go instance uses klog and does. However, Cobra doesn't play nicely with it; we need to figure out how to make it handle the klog flags properly.The text was updated successfully, but these errors were encountered: