doc(kic) remove stderrthreshold flag #2835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the --stderrthreshold flag from KIC documentation. This is a leftover from an old logging library we used prior to 0.10.0. It hasn't actually been available since.
|
Deploy preview for kongdocs ready! Built with commit 3a2fdb6 |
|
It appears that the k8s api machinery does use this flag, and it's being registered using a separate unrelated mechanism. So I think that the appropriate fix here is not to remove this flag from the documentation, but to ensure that this flag works in Railgun. |
|
Aight, nevermind then. Kong/kubernetes-ingress-controller#1297 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the --stderrthreshold flag from KIC documentation. This is a leftover from an old logging library we used prior to 0.10.0. It hasn't actually been available since.
Reason
Found when reviewing log flag updates for KIC 2.0: Kong/kubernetes-ingress-controller#1294 (review)