Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPCRoute tranlator cannot handle wildcard rule #4154

Closed
2 tasks
rainest opened this issue Jun 8, 2023 · 0 comments · Fixed by #4512
Closed
2 tasks

gRPCRoute tranlator cannot handle wildcard rule #4154

rainest opened this issue Jun 8, 2023 · 0 comments · Fixed by #4512
Assignees
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API bug Something isn't working priority/medium
Milestone

Comments

@rainest
Copy link
Contributor

rainest commented Jun 8, 2023

Prior to kubernetes-sigs/gateway-api#1753, the gRPC spec provided a default method match if no matches were specified. This broke the intended meaning of a no-match rule, which should match all requests.

The gRPC route translator loops over matches to generate routes associated with a GRPCRoute resource. If a rule has no matches, it will result in 0 associated routes. I did not review the ATC generator behavior.

The current example test manifest uses a 0-match rule. After upgrading the Gateway APIs CRDs to 0.7.1, API requests no longer populated default matches for it. This results in the translator generating 0 routes, whereas it should instead generate a single route that matches any request for example.com

To fix:

  • When GWAPI 0.7.1 is installed, a 0-match gRPC rule must generate a single Kong route that matches all requests that match the GRPCRoute hostname with the traditional router.
  • The same is true with the expression router.
@rainest rainest added bug Something isn't working area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API priority/medium labels Jun 8, 2023
@randmonkey randmonkey self-assigned this Jun 8, 2023
@randmonkey randmonkey added this to the KIC v2.11.0 milestone Jun 8, 2023
@randmonkey randmonkey removed their assignment Jun 8, 2023
@mflendrich mflendrich modified the milestones: KIC v2.11.0, KIC v2.12.0 Jun 14, 2023
@randmonkey randmonkey self-assigned this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API bug Something isn't working priority/medium
Projects
None yet
3 participants