Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing GRPC conformance test #6136

Closed
2 of 3 tasks
lahabana opened this issue Jun 5, 2024 · 3 comments · Fixed by #6166
Closed
2 of 3 tasks

Fix failing GRPC conformance test #6136

lahabana opened this issue Jun 5, 2024 · 3 comments · Fixed by #6166
Assignees
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API
Milestone

Comments

@lahabana
Copy link
Contributor

lahabana commented Jun 5, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Does this enhancement require public documentation?

  • I have added an Acceptance Criteria item for adding and/or adjusting public documentation (if applicable)

Problem Statement

As pointed in: https://github.com/Kong/kubernetes-ingress-controller/pull/5776/files#r1611405584

we have a few tests that do not pass with our GRPC route implementation. @tao12345666333 looked into and it seems to be a KIC problem and not a gateway problem so we should be able to make them pass

Proposed Solution

  • Pass the host that has been configured in Gateway to the final generated route.

Additional information

No response

Acceptance Criteria

  • The GRPCRoute conformance GRPCRouteListenerHostnameMatching tests pass in Traditional mode
@lahabana lahabana added this to the KIC v3.2.x milestone Jun 5, 2024
@lahabana lahabana added the area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API label Jun 5, 2024
@pmalek
Copy link
Member

pmalek commented Jun 6, 2024

The GRPC conformance enabled in #5776 seems to be failing for traditional copmatible router https://app.buildpulse.io/@Kong/kubernetes-ingress-controller/tests/17956419004?filter_results_type=flaky

example: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/9404948579/job/25905145650

The problematic test case seems to be

2024-06-06T17:11:27.8393367Z         --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/3_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:blue,Version:two}'_should_go_to_grpc-infra-backend-v2 (30.00s)

@pmalek pmalek added the kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API label Jun 6, 2024
@tao12345666333
Copy link
Member

tao12345666333 commented Jun 6, 2024

@tao12345666333
Copy link
Member

tao12345666333 commented Jun 7, 2024

@pmalek I will use this issue for tracking #6144

For now I have skipped
tests.GRPCRouteHeaderMatching.ShortName and enable tests.GRPCExactMethodMatching.ShortName

It will get a more stable result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants