Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill protocol field in Kong routes when translating to expression routes #4313

Closed
1 task
randmonkey opened this issue Jul 11, 2023 · 0 comments · Fixed by #4422
Closed
1 task

Fill protocol field in Kong routes when translating to expression routes #4313

randmonkey opened this issue Jul 11, 2023 · 0 comments · Fixed by #4422
Assignees
Labels
area/kong Issue with Kong proxy behavior, rather than the controller
Milestone

Comments

@randmonkey
Copy link
Contributor

randmonkey commented Jul 11, 2023

As suggestion from gateway team, it is better to put protocols in protocols field of Kong routes, instead of adding net.protocol == *** in expressions.

Currently the parser will put protocol matchers in expressions, including adding the default (net.protocol == "http") || (net.protocol) == “https”. We should move the matching rules of protocols into protocols field of translated Kong routes, as we did for traditional router.

Acceptance Criteria

  • When generate expression based Kong routes, protocols are put in protocols field of routes but not in Expressions
@randmonkey randmonkey added this to the KIC v2.11.0 milestone Jul 28, 2023
@randmonkey randmonkey self-assigned this Jul 28, 2023
@randmonkey randmonkey added the area/kong Issue with Kong proxy behavior, rather than the controller label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kong Issue with Kong proxy behavior, rather than the controller
Projects
None yet
1 participant