Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expression router) move setting protocols back to kongstate override for expression based routes #4422

Merged
merged 5 commits into from
Jul 31, 2023

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Jul 28, 2023

What this PR does / why we need it:

As suggested by gateway team, it is better to configure the protocols of Kong routes in protocols field than filling them directly into the expression. This PR moves the filling protocol back to the kongstate override phase of generated Kong routes, as with traditional router.

Which issue this PR fixes:

fixes #4313

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner July 28, 2023 07:14
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 100.0% and project coverage change: +0.2% 🎉

Comparison is base (1e260dd) 67.5% compared to head (4a1154a) 67.7%.
Report is 1 commits behind head on main.

❗ Current head 4a1154a differs from pull request most recent head 08899b2. Consider uploading reports for the commit 08899b2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4422     +/-   ##
=======================================
+ Coverage   67.5%   67.7%   +0.2%     
=======================================
  Files        159     159             
  Lines      18803   18772     -31     
=======================================
+ Hits       12699   12724     +25     
+ Misses      5340    5284     -56     
  Partials     764     764             
Files Changed Coverage Δ
...rnal/dataplane/parser/translators/grpcroute_atc.go 92.9% <ø> (-0.2%) ⬇️
...ternal/dataplane/parser/translators/ingress_atc.go 94.7% <ø> (+4.6%) ⬆️
internal/dataplane/kongstate/route.go 90.9% <100.0%> (ø)
...rnal/dataplane/parser/translators/httproute_atc.go 95.2% <100.0%> (-0.9%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo
Copy link
Contributor

Allowed myself to rebase onto main and regenerate golden files (needed after #4426).

@randmonkey randmonkey force-pushed the fill_protocols_for_expression_routes branch from 4b4513a to 702376f Compare July 31, 2023 07:46
@randmonkey randmonkey force-pushed the fill_protocols_for_expression_routes branch from d4fcdb8 to 4a1154a Compare July 31, 2023 07:52
CHANGELOG.md Outdated Show resolved Hide resolved
@randmonkey randmonkey requested a review from pmalek July 31, 2023 09:28
@pmalek pmalek added this to the KIC v2.11.0 milestone Jul 31, 2023
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@randmonkey randmonkey enabled auto-merge (squash) July 31, 2023 09:33
@randmonkey randmonkey merged commit b82308e into main Jul 31, 2023
29 checks passed
@randmonkey randmonkey deleted the fill_protocols_for_expression_routes branch July 31, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fill protocol field in Kong routes when translating to expression routes
4 participants