Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Runtime Groups to Control Plane #4466

Closed
5 tasks done
mheap opened this issue Aug 8, 2023 · 1 comment · Fixed by #4566
Closed
5 tasks done

Rename Runtime Groups to Control Plane #4466

mheap opened this issue Aug 8, 2023 · 1 comment · Fixed by #4566
Assignees
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality.
Milestone

Comments

@mheap
Copy link
Member

mheap commented Aug 8, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

The Runtime Group terminology is being phased out in support of Control Plane in Konnect

Proposed Solution

  • Replace all usage of the term Runtime Group in public facing configuration/logs with Control Plane
  • Replace the path ~/kic/api/runtime_groups/(?<rgid>\S+?)/(?<path>\S+) with ~/kic/api/control_planes/(?<rgid>\S+?)/(?<path>\S+)
  • Replace the path ~/kic/api/runtime_groups/(?<rgid>\S+?)/oauth2 with ~/kic/api/control_planes/(?<rgid>\S+?)/oauth2

Additional information

Refactoring internal method names away from Runtime Group is optional, but recommended

Acceptance Criteria

  • konnect-runtime-group-id CLI flag is deprecated, konnect-control-plane-id is introduced instead
  • internal/konnect/runtimegroups package uses ControlPlane naming instead of RuntimeGroup for its types and functions
  • tests and test helpers do not use RuntimeGroup term
  • internal/dataplane/sendconfig package does not use RuntimeGroup term
@mflendrich
Copy link
Contributor

Reopening to determine the scope of the remaining work (at least check if log prints, flag names, or as @randmonkey pointed out - object names in the code) need changing.
Then please put them in the ACs and shepherd this effort through completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality.
Projects
None yet
3 participants