-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate --konnect-runtime-group-id flag #4783
Conversation
d9ee0ea
to
f345135
Compare
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6456059397 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4783 +/- ##
=====================================
Coverage 77.6% 77.6%
=====================================
Files 163 163
Lines 18520 18523 +3
=====================================
+ Hits 14381 14389 +8
+ Misses 3326 3322 -4
+ Partials 813 812 -1
☔ View full report in Codecov by Sentry. |
f345135
to
f8e5d1d
Compare
fde4d32
to
8112150
Compare
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6458313363 |
What this PR does / why we need it:
Deprecates
--konnect-runtime-group-id
CLI flag, introduces--konnect-control-plane-id
instead.Which issue this PR fixes:
Part of #4466.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR