Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate --konnect-runtime-group-id flag #4783

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Oct 9, 2023

What this PR does / why we need it:

Deprecates --konnect-runtime-group-id CLI flag, introduces --konnect-control-plane-id instead.

Which issue this PR fixes:

Part of #4466.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@czeslavo czeslavo force-pushed the konnect-control-plane-flag branch 2 times, most recently from d9ee0ea to f345135 Compare October 9, 2023 11:32
@czeslavo czeslavo added area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/konnect Issues and PRs related to Konnect labels Oct 9, 2023
@czeslavo czeslavo self-assigned this Oct 9, 2023
@czeslavo czeslavo added this to the KIC v3.0.0 milestone Oct 9, 2023
@czeslavo czeslavo added the ci/run-e2e Trigger e2e test run from PR label Oct 9, 2023
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6456059397

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6a951b1) 77.6% compared to head (8112150) 77.6%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4783   +/-   ##
=====================================
  Coverage   77.6%   77.6%           
=====================================
  Files        163     163           
  Lines      18520   18523    +3     
=====================================
+ Hits       14381   14389    +8     
+ Misses      3326    3322    -4     
+ Partials     813     812    -1     
Files Coverage Δ
internal/konnect/license/client.go 82.9% <100.0%> (ø)
internal/manager/config.go 94.7% <100.0%> (+<0.1%) ⬆️
internal/manager/config_validation.go 83.1% <100.0%> (ø)
internal/konnect/nodes/client.go 0.0% <0.0%> (ø)
internal/adminapi/konnect.go 0.0% <0.0%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo marked this pull request as ready for review October 9, 2023 13:50
@czeslavo czeslavo requested a review from a team as a code owner October 9, 2023 13:50
Makefile Outdated Show resolved Hide resolved
@czeslavo czeslavo added the ci/run-e2e Trigger e2e test run from PR label Oct 9, 2023
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6458313363

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Oct 9, 2023
@czeslavo czeslavo enabled auto-merge (squash) October 9, 2023 15:12
@czeslavo czeslavo merged commit 98cedfb into main Oct 9, 2023
182 checks passed
@czeslavo czeslavo deleted the konnect-control-plane-flag branch October 9, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/konnect Issues and PRs related to Konnect area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants