Remove Ingress API selection code #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainest
force-pushed
the
chore/ingress-controller-selection
branch
2 times, most recently
from
7d18f84
to
bd94cd5
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4643 +/- ##
=======================================
+ Coverage 68.0% 68.1% +0.1%
=======================================
Files 163 162 -1
Lines 19091 19028 -63
=======================================
- Hits 12992 12974 -18
+ Misses 5331 5285 -46
- Partials 768 769 +1
☔ View full report in Codecov by Sentry. |
Remove Ingress API selection in favor of simply honoring the CLI disable flag. Support for Ingress versions other than networking/v1 was removed in #3867. The API selection code was only selecting between networking/v1 and nothing. Future Kubernetes versions are not expected to abruptly remove the older API versions if they introduce new Ingress versions, so this selection code should not be necessary in the future.
rainest
force-pushed
the
chore/ingress-controller-selection
branch
from
bd94cd5
to
24a50c5
Compare
pmalek
approved these changes
Sep 12, 2023
czeslavo
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes the Ingress API selection code and just honor the flag. There were no options other than networking/v1 and nothing after #3867. Nothing should not occur in practice for standard APIs, and the code actually selecting that probably means something has gone wrong.
Ditto for the IngressClass controller.
Special notes for your reviewer:
Also adds the changelog for #4641, since I forgot to check that when reviewing it.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR