-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove support for netv1beta1.Ingress #3867
Conversation
9009a38
to
3995d32
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3867 +/- ##
======================================
Coverage ? 58.4%
======================================
Files ? 140
Lines ? 15759
Branches ? 0
======================================
Hits ? 9219
Misses ? 5915
Partials ? 625
☔ View full report in Codecov by Sentry. |
3995d32
to
631f4c8
Compare
7f157ae
to
ed38e01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
ed38e01
to
07407f9
Compare
Remove Ingress API selection in favor of simply honoring the CLI disable flag. Support for Ingress versions other than networking/v1 was removed in #3867. The API selection code was only selecting between networking/v1 and nothing. Future Kubernetes versions are not expected to abruptly remove the older API versions if they introduce new Ingress versions, so this selection code should not be necessary in the future.
Remove Ingress API selection in favor of simply honoring the CLI disable flag. Support for Ingress versions other than networking/v1 was removed in #3867. The API selection code was only selecting between networking/v1 and nothing. Future Kubernetes versions are not expected to abruptly remove the older API versions if they introduce new Ingress versions, so this selection code should not be necessary in the future.
Remove Ingress API selection in favor of simply honoring the CLI disable flag. Support for Ingress versions other than networking/v1 was removed in #3867. The API selection code was only selecting between networking/v1 and nothing. Future Kubernetes versions are not expected to abruptly remove the older API versions if they introduce new Ingress versions, so this selection code should not be necessary in the future.
Remove Ingress API selection in favor of simply honoring the CLI disable flag. Support for Ingress versions other than networking/v1 was removed in #3867. The API selection code was only selecting between networking/v1 and nothing. Future Kubernetes versions are not expected to abruptly remove the older API versions if they introduce new Ingress versions, so this selection code should not be necessary in the future.
* chore(docs) add #4641 changelog entry * chore(controllers) remove Ingress API selection Remove Ingress API selection in favor of simply honoring the CLI disable flag. Support for Ingress versions other than networking/v1 was removed in #3867. The API selection code was only selecting between networking/v1 and nothing. Future Kubernetes versions are not expected to abruptly remove the older API versions if they introduce new Ingress versions, so this selection code should not be necessary in the future.
What this PR does / why we need it:
This PR removes support for netv1beta1 Ingress which is not served anymore as of kubernetes 1.22+: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122
Which issue this PR fixes:
Closes #1666
Special notes for your reviewer:
The service and route names had to be adjusted in tests (where I've managed to replace netv1beta1 with netv1 Ingresses).
Also
RegexPriority
is treated a little bit differently for v1 Ingresses:kubernetes-ingress-controller/internal/dataplane/parser/translate_ingress.go
Line 268 in 56a11b9
Most of the changes required to be made were in
internal/dataplane/parser/parser_test.go
which instead of relying on v1beta1Ingress
, now relies onnetworking.k8s.io/v1
Ingress
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR